Repository navigation
perf(pipeline): skip redundant binding reads for silent stage output - #2777
Merged
Merged
Conversation
This was referenced Oct 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
huanghuoguoguo
marked this pull request as ready for review
October 27, 2026 03:19
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Silent intermediate pipeline results currently trigger binding reads even when they have no output or other effects. Skip that redundant check while retaining guards before every user/debug/console/error notice and a fresh guard after the stage chain, before reporting success.
A three-stage SQLite regression reduces binding SELECTs from 6 to 4. Stale generation still rejects final empty output; this is not a binding cache.
Related: #2709. This addresses one source of redundant reads, not the entire performance issue.
Validation
On this independently split branch:
pytest tests/unit_tests/pipeline/test_pipelinemgr.py tests/unit_tests/pipeline/test_terminal_monitoring.py tests/unit_tests/pipeline/test_monitoring_failure.py -q: 33 passed.The combined candidate also exercised real Docker Box and MiniLM/Chroma with deterministic mock generation. These bounded checks do not establish general throughput improvement or eliminate the existing SQLite/deadline failures. Kept as draft while overall performance acceptance remains incomplete.
Related review pieces
Author checklist