Skip to content

perf(pipeline): skip redundant binding reads for silent stage output - #2777

Merged
huanghuoguoguo merged 1 commit into
masterfrom
perf/pipeline-empty-output-fences-2709
Oct 27, 2026
Merged

huanghuoguoguo merged 1 commit into
masterfrom
perf/pipeline-empty-output-fences-2709

Conversation

@huanghuoguoguo

@huanghuoguoguo huanghuoguoguo commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

Silent intermediate pipeline results currently trigger binding reads even when they have no output or other effects. Skip that redundant check while retaining guards before every user/debug/console/error notice and a fresh guard after the stage chain, before reporting success.

A three-stage SQLite regression reduces binding SELECTs from 6 to 4. Stale generation still rejects final empty output; this is not a binding cache.

Related: #2709. This addresses one source of redundant reads, not the entire performance issue.

Validation

On this independently split branch: pytest tests/unit_tests/pipeline/test_pipelinemgr.py tests/unit_tests/pipeline/test_terminal_monitoring.py tests/unit_tests/pipeline/test_monitoring_failure.py -q: 33 passed.

The combined candidate also exercised real Docker Box and MiniLM/Chroma with deterministic mock generation. These bounded checks do not establish general throughput improvement or eliminate the existing SQLite/deadline failures. Kept as draft while overall performance acceptance remains incomplete.

Related review pieces

Author checklist

  • Read CONTRIBUTING.md.
  • Ran the focused checks listed above on this independent branch.
  • CLA status to be verified by the repository bot.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@huanghuoguoguo
huanghuoguoguo marked this pull request as ready for review October 27, 2026 03:19
@huanghuoguoguo
huanghuoguoguo merged commit fd255a1 into master Oct 27, 2026
31 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-27T03:19:37.125687Z 5f270b9 Draft marked ready
🔒 Security Review 🔄 Running since 2026-10-27T03:19:37.453156Z 5f270b9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant